Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(installer): fix grafana template fromat error in volcano-monitoring-latest.yaml #3190

Closed
wants to merge 1 commit into from

Conversation

Xu-Wentao
Copy link

Some values like \{\{ can't be recognized by grafana, we need to change them to \\{\\{.

@volcano-sh-bot
Copy link
Contributor

Welcome @Xu-Wentao!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 10, 2023
@Xu-Wentao
Copy link
Author

/assign @william-wang

@william-wang
Copy link
Member

Triger the ci.

@Xu-Wentao
Copy link
Author

Triger the ci.

I'm new here, can you tell me how to triger the ci, :)

@Monokaix
Copy link
Member

Fixed by #3262

@Monokaix
Copy link
Member

/close

@volcano-sh-bot
Copy link
Contributor

@Monokaix: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Xu-Wentao Xu-Wentao deleted the bugfix branch January 12, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants