⚡ jobflow-controller jobtemplate-controller enqueue should use struct not pointer

[kingeasternsun]

Why should not use pointer

The workqueue will deduplicate same item in queue.
According the internal struct of workqueue, when we add a item to workqueue firstly, workqueue will also put it in q.dirty which is `map[interface]struct{}``

// Add marks item as needing processing.
func (q *Type) Add(item interface{}) {
	
    ...

	q.dirty.insert(item)
	if q.processing.has(item) {
		return
	}

	q.queue = append(q.queue, item)
	q.cond.Signal()
}

before this item processed, if same item re added to the workqueue , this add will skiped

// Add marks item as needing processing.
func (q *Type) Add(item interface{}) {
	q.cond.L.Lock()
	defer q.cond.L.Unlock()
	if q.shuttingDown {
		return
	}
	if q.dirty.has(item) {
		return
	}
    ...
}

the current code use *apis.FlowRequest as item to add to the workqueue, even the different apis.FlowRequest have same values, different *apis.FlowRequest will be considerd as different item in workqueue, so the deduplication is not work.

We can try the example code blow,

type empty struct{}
type t interface{}
type set map[t]empty

func (s set) has(item t) bool {
	_, exists := s[item]
	return exists
}

func (s set) insert(item t) {
	s[item] = empty{}
}

func (s set) delete(item t) {
	delete(s, item)
}

func CompareMap() {
	a := &FlowRequest{Namespace: "a", JobFlowName: "n"}
	a1 := &FlowRequest{Namespace: "a", JobFlowName: "n"}
	b := &FlowRequest{Namespace: "b", JobFlowName: "n"}

	frMap := set{}
	frMap.insert(a)
	fmt.Println(frMap.has(a1))
	fmt.Println(frMap.has(b))
}
func CompareMapB() {
	a := FlowRequest{Namespace: "a", JobFlowName: "n"}
	a1 := FlowRequest{Namespace: "a", JobFlowName: "n"}
	b := FlowRequest{Namespace: "b", JobFlowName: "n"}

	frMap := set{}
	frMap.insert(a)
	fmt.Println(frMap.has(a1))
	fmt.Println(frMap.has(b))

}

the CompareMap will Print

false
false

the CompareMapB will Print

true
false

[kingeasternsun]

/assign @hwdef, could u review this please, thanks.

[hwdef]

/lgtm

[william-wang]

/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controllers/OWNERS [william-wang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment