Added job's MinResource check once job is poped from queue

[srikanth-iyengar]

fix #3047

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[srikanth-iyengar]

/hold

[srikanth-iyengar]

Hey @lowang-bh can you review this PR ?

[srikanth-iyengar]

hey @lowang-bh can you review this pr ?

[lowang-bh]

hey @lowang-bh can you review this pr ?

I think you can first get job's minResource, and use compare function in the lib.

[srikanth-iyengar]

/assign

[srikanth-iyengar]

/test all

[volcano-sh-bot]

@srikanth-iyengar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[srikanth-iyengar]

@lowang-bh will this work?

                jobMinResource := job.GetMinResources()
		queueAllocatedResource := api.NewResource(queue.Queue.Status.Allocated)
		queueCapability := api.NewResource(queue.Queue.Spec.Capability)
		if jobMinResource.Add(queueAllocatedResource).Less(queueCapability, api.Zero) {
			klog.V(4).Infof("Queue <%s> is overused when considering job <%s>, ignore it.", queue.Name, job.Name)
			continue
		}

[srikanth-iyengar]

Hey @lowang-bh Can you check on the changes ?

[lowang-bh]

Hey @lowang-bh Can you check on the changes ?

How about first to pick some good first issue, eg the UTs, to familar with volcano? It will help you to understand the full archtechure and scheduling process.

[srikanth-iyengar]

Yeah, Got it thanks for suggestions, I guess it will really help me

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.