Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the reclaim bugs: push back the queue to queues in reclaim #3004

Closed

Conversation

RamezesDong
Copy link

fix #3003

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
@RamezesDong
Copy link
Author

/assign @Thor-wl

@RamezesDong RamezesDong changed the title fix: push back the queue to queues in reclaim fix the reclaim bugs: push back the queue to queues in reclaim Jul 27, 2023
@lowang-bh
Copy link
Member

lowang-bh commented Jul 27, 2023

Thanks very much for your contributions. It will be more perfect if there are some UTs which will prevent others breaking the code in the features.

@RamezesDong
Copy link
Author

I'd be glad to add some UTs for this pr.

@Thor-wl
Copy link
Contributor

Thor-wl commented Aug 1, 2023

/assign @Thor-wl

Thanks for the reminder. Let me take a overlook recently.

@Thor-wl Thor-wl requested review from william-wang, lowang-bh and Thor-wl and removed request for k82cn and alcorj-mizar August 1, 2023 08:26
@william-wang
Copy link
Member

@wangyang0616 Please help to review as well.

@@ -106,18 +106,21 @@ func (ra *Action) Execute(ssn *framework.Session) {

Copy link
Member

@wangyang0616 wangyang0616 Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this problem, is it possible to add queues.Push(queue) here, and then delete queues.Push(queue) on line 200?

There is similar processing in allocate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the order of the code.

@stale
Copy link

stale bot commented Oct 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2023
Signed-off-by: RamezesDong <[email protected]>
@stale stale bot closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reclaim action push queue bugs, maybe cause the reclaiming reouces invalid
6 participants