Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the pod pipeline status is incompatible with autoscaler capacity expansion #3001

Merged

Conversation

wangyang0616
Copy link
Member

fix: Scale-out cannot be triggered by autoscaler for pods in the pipeline state #3000

If a terminating pod exists in a cluster, the pod queues up and waits for the terminating pod to release resources. Then the scheduling is successful. In the current scheduling period, pods in the pipeline state fail to be scheduled. Therefore, it is more appropriate to set the reason of pod status to Unschedulable.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
…od. It is more reasonable to set reason to Unschedulable and compatible with autoscaler capacity expansion

Signed-off-by: w00568049 <[email protected]>
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@volcano-sh-bot volcano-sh-bot merged commit 13f60b8 into volcano-sh:master Jul 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale-out cannot be triggered by autoscaler for pods in the pipeline state
3 participants