Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scheduler metric e2e_scheduling_latency_milliseconds #2970

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix scheduler metric e2e_scheduling_latency_milliseconds #2970

merged 1 commit into from
Jul 27, 2023

Conversation

WulixuanS
Copy link
Contributor

fix #2969

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2023
@lowang-bh
Copy link
Member

lowang-bh commented Jul 25, 2023 •
edited
Loading

LGTM. @hwdef @wangyang0616 please help to review. Thanks.

@hwdef
Copy link
Member

hwdef commented Jul 25, 2023

LGTM. @hwdef @wangyang0616 please help to review. Thanks.

You are already a reviewer.
You can use /lgtm command to add lgtm label.

@lowang-bh
Copy link
Member

You are already a reviewer. You can use /lgtm command to add lgtm label.

Yes，I mean it's better to have 2-3 lgtms each pr.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@hwdef
Copy link
Member

hwdef commented Jul 26, 2023

You are already a reviewer. You can use /lgtm command to add lgtm label.

Yes，I mean it's better to have 2-3 lgtms each pr.

/lgtm

In principle, we only need one lgtm and one approve.

If we need more lgtm, you know, then PR will be harder to merge.

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
william-wang
william-wang approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@volcano-sh-bot volcano-sh-bot merged commit dd7fee9 into volcano-sh:master Jul 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@merryzhou merryzhou Awaiting requested review from merryzhou

Assignees

@william-wang william-wang

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduler metric e2e_scheduling_latency_milliseconds not correct
5 participants
@WulixuanS @lowang-bh @hwdef @volcano-sh-bot @william-wang