Add NodeOrder to devices API #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
|
/assign @william-wang @wangyang0616 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,65 @@ | |||
| /* | |||
| Copyright 2018 The Kubernetes Authors. | |||
There was a problem hiding this comment.
The time here can be updated.
| if !devices.HasDeviceRequest(task.Pod) { | ||
| continue | ||
| } | ||
| tmp, err := devices.ScoreNode(task.Pod) |
There was a problem hiding this comment.
Is there a better way to name the tmp variable?
| klog.Warningln("scoreNode failed in predicate nodeorderFn", err.Error()) | ||
| return 0, err | ||
| } | ||
| score += tmp |
There was a problem hiding this comment.
Does deveice's scoring strategy support weight configuration?
volcano-sh-bot
added
size/L
Add NodeOrder to devices API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NodeOrder to devices API. Devices API should provide the ability to score each node based on corresponding device information of this node. A device which don't want to participate in score process, can simply return a (0,nil) in ScoreNode.
Future work includes implement "Mellanox" device in devices API, which can provide more accurate scheduling decision making based on Infiniband-network topology. It is crucial for large-scale training cluster which uses mellanox for InfiniBand data exchange.