Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers.yaml clusterRole add  flow.volcano.sh #2951

Closed
wants to merge 3 commits into from
Closed

controllers.yaml clusterRole add  flow.volcano.sh #2951

wants to merge 3 commits into from

Conversation

wangzhipeng
Copy link

增加flow.volcano.sh权限

@lowang-bh
Copy link
Member

lowang-bh commented Jul 4, 2023 •
edited
Loading

It is ok to me.

But It is strange, why does it work before this pr when there is no create verb for jobs?

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 14, 2023
@lowang-bh lowang-bh mentioned this pull request Jul 20, 2023
Closed
@wangzhipeng
Copy link
Author

@william-wang

@lowang-bh
Copy link
Member

lowang-bh commented Jul 21, 2023 •
edited
Loading

It is ok to me.

One issue left to be solve: please run make update-development-yamll to update deployment yaml

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@lowang-bh
Copy link
Member

/hold

@volcano-sh-bot volcano-sh-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@lowang-bh
Copy link
Member

lowang-bh commented Jul 25, 2023 •
edited
Loading

@wangzhipeng Please rebase from master and update the pr again. thanks. BTW, don't forget run make update-development-yaml

@lowang-bh lowang-bh mentioned this pull request Jul 27, 2023
Merged
@lowang-bh
Copy link
Member

There is already a same pr merged.
/close

@volcano-sh-bot
Copy link
Contributor

@lowang-bh: Closed this PR.

In response to this:

There is already a same pr merged.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thor-wl Thor-wl Thor-wl approved these changes

Assignees

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangzhipeng @lowang-bh @volcano-sh-bot @Thor-wl