-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't need gen-code anymore in this repo's code #2891
base: master
Are you sure you want to change the base?
Conversation
trigger ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this solution is related to issue.
Don't we need verify gencode?
Becasue we are use apis in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lowang-bh please help to solve the confliction:) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Done. |
/assign @hwdef @william-wang @Thor-wl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@lowang-bh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
/remove lifecycle |
/assign @Monokaix |
Please resolve code confliction. |
New changes are detected. LGTM label has been removed. |
It occurs to me that we have a plan to move api repo to volcano staging dir, because these two repoes are closely linked. So I think move api to current repo is more meaningful, and then we will need this script. If anyone is interested, welcome to contribute. Related issue: #2356 |
Signed-off-by: lowang-bh <[email protected]>
@lowang-bh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix #2878, as it describes, it will generate codes in apis dir when run make verify at local env. Remove it from code becualse code-generate is move to apis repo.
/kind clean-up