Skip to content

Commit

Permalink
add docs about un-enqueueable reason
Browse files Browse the repository at this point in the history
Signed-off-by: lowang-bh <[email protected]>
  • Loading branch information
lowang-bh committed Aug 20, 2023
1 parent 54e3b40 commit 8d8dd4e
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions docs/design/podgroup-condition-reason.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# podgroup conditions

## Backgrounds

Currently, there are only two podgroup condition type: `Unschedulable` and `Scheduled`. If job is not enqueued, it has not been scheduled. And the event reason is `Unschedulable` and podgroup condition reason is `NotEnoughResources`. These reasons is not coresponding with the real reason `job is not enqueued`

## Motivation

In order to classify the uninqueueable reason from other unscheduleable reasons

## Design

1. add `Uninqueueable` reason for podgroup events

```go
// PodGroupUnInqueueable is Uninqueueable event type
PodGroupUnInqueueable PodGroupConditionType = "Uninqueueable"
```

2. add `NotInqueueable` reason for podgroup conditions reason

```go
// NotInqueueableReason if probed if job is rejected to enqueue
NotInqueueableReason string = "NotInqueueable"
```

0 comments on commit 8d8dd4e

Please sign in to comment.