Merge pull request #98 from DieterHolvoet/fix-no-parent

Fix error in parent() method if no parent node
voku · May 25, 2024 · 46dc4cd · 46dc4cd
2 parents 4e8e9d4 + ec3b25e
commit 46dc4cd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/src/voku/helper/SimpleHtmlDom.php b/src/voku/helper/SimpleHtmlDom.php
@@ -684,11 +684,15 @@ public function nextNonWhitespaceSibling()
  /**
  * Returns the parent of node.
  *
- * @return SimpleHtmlDomInterface
+ * @return SimpleHtmlDomInterface|null
  */
- public function parentNode(): SimpleHtmlDomInterface
+ public function parentNode(): ?SimpleHtmlDomInterface
  {
- return new static($this->node->parentNode);
+ if ($node = $this->node->parentNode) {
+ return new static($node);
+ }
+
+ return null;
  }
 
  /**

diff --git a/src/voku/helper/SimpleHtmlDomBlank.php b/src/voku/helper/SimpleHtmlDomBlank.php
@@ -402,9 +402,9 @@ public function previousNonWhitespaceSibling()
  /**
  * Returns the parent of node.
  *
- * @return SimpleHtmlDomInterface
+ * @return SimpleHtmlDomInterface|null
  */
- public function parentNode(): SimpleHtmlDomInterface
+ public function parentNode(): ?SimpleHtmlDomInterface
  {
  return new static();
  }

diff --git a/src/voku/helper/SimpleHtmlDomInterface.php b/src/voku/helper/SimpleHtmlDomInterface.php
@@ -324,9 +324,9 @@ public function previousNonWhitespaceSibling();
  /**
  * Returns the parent of node.
  *
- * @return SimpleHtmlDomInterface
+ * @return SimpleHtmlDomInterface|null
  */
- public function parentNode(): self;
+ public function parentNode(): ?self;
 
  /**
  * Returns the previous sibling of node.