Add kernel culling and server shutdown timeouts #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
commented
Jun 21, 2019
| cmd = 'jupyter-notebook' | ||
|
|
||
| # rm containers when they stop | ||
| remove = True |
There was a problem hiding this comment.
This is not picked up when the server is shut down (still shows in docker ps -a).
Probably because it is used only when its stop method is called, not when the notebook server (pid 1) stops.
|
It's one of the things mybinder.org uses - we still run the culler since we want to delete the active users as well once their servers stop. Otherwise we'll end up with a ton of them in our sqlite db... This is a good call in the interim though. |
|
True. For reference, the change to enable the auto remove of the Docker containers when the process exits (on the daemon side): jupyterhub/dockerspawner#318. (At the moment the containers are stopped but not removed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different and perhaps simpler approach to shutting down idle servers (compared to #33)
The notebook server shuts itself down after a period of inactivity instead of being actively culled by the hub.
This should also be similar to what mybinder.org is currently doing: https://github.com/jupyterhub/mybinder.org-deploy/blob/ddabade54008c2fcdf936812eabff3c0093362d5/mybinder/values.yaml#L8-L22