end2endtest account: fixes

[mariajdab]

Remove log.Fatal use and check concurrency the balance/nonce and token transfer count

[mariajdab]

could you please take a look @altergui? The error said Process completed with exit code 2. but there is not more information

[altergui]

reading the diff, LGTM. i'll try to reproduce the error you mention

[altergui]

miner2 and miner3 panic'ed at the same time. output is very confusing since it's intertwined

https://github.com/vocdoni/vocdoni-node/actions/runs/7000208867/job/19040533596#step:4:2778

panic: sync: negative WaitGroup counter

goroutine 133 [running]:
sync.(*WaitGroup).Add(0xc000483770, 0xffffffffffffffff)
	sync/waitgroup.go:62 +0x1cd
sync.(*WaitGroup).Done(0x473be2ac281f27a8?)
	sync/waitgroup.go:87 +0x2e
main.testSendTokens.func5()
	go.vocdoni.io/dvote/cmd/end2endtest/account.go:277 +0x3d6
created by main.testSendTokens in goroutine 1
	go.vocdoni.io/dvote/cmd/end2endtest/account.go:270 +0x1bd6

testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/tree.(*Tree).Get()
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/tree/tree.go:70 +0x144
testsuite_7000208867-miner2-1    |   github.com/cockroachdb/pebble.(*Iterator).First()
testsuite_7000208867-miner0-1    | 2023-11-27T03:26:57.661Z INF vochain/app.go:198 > commit block height=41 txs=12
testsuite_7000208867-miner2-1    |       github.com/cockroachdb/[email protected]/iterator.go:1605 +0x33d
testsuite_7000208867-miner0-1    | 2023-11-27T03:26:57.673Z INF comet: committed state block_app_hash=F45155B4901A275CF09CDEA966DE6353F3BAC62999BF23A5A2C74F0C3A6D2CCD height=41
testsuite_7000208867-miner2-1    |   github.com/cockroachdb/pebble.(*DB).getInternal()
testsuite_7000208867-miner0-1    | 2023-11-27T03:26:57.684Z INF comet: indexed block events height=41
testsuite_7000208867-miner2-1    |       github.com/cockroachdb/[email protected]/db.go:595 +0x6c9
testsuite_7000208867-miner2-1    |   github.com/cockroachdb/pebble.(*Batch).Get()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/statedb.(*TreeUpdate).Get()
testsuite_7000208867-miner2-1    |       github.com/cockroachdb/[email protected]/batch.go:553 +0xa4
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/statedb/treeupdate.go:63 +0x207
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/db/pebbledb.get()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/statedb.(*TreeUpdate).DeepGet()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/db/pebbledb/pebledb.go:21 +0xb9
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/statedb/treeupdate.go:192 +0x110
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/db/pebbledb.(*WriteTx).Get()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/statedb.(*treeUpdateView).DeepGet()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/db/pebbledb/pebledb.go:69 +0xa7
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/statedb/treeupdate.go:378 +0xd2
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/db/prefixeddb.(*PrefixedWriteTx).Get()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/vochain/state.getProcess()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/db/prefixeddb/prefixeddb.go:117 +0x227
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/vochain/state/process.go:86 +0x1ae
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/tree/arbo.(*Tree).down()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/vochain/state.(*State).Process()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/tree/arbo/navigate.go:24 +0x1db
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/vochain/state/process.go:106 +0x27b
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/tree/arbo.(*Tree).down()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/vochain/keykeeper.(*KeyKeeper).checkRevealProcess()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/tree/arbo/navigate.go:77 +0x824
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/vochain/keykeeper/keykeeper.go:371 +0x608
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/tree/arbo.(*Tree).down()
testsuite_7000208867-miner3-1    |   go.vocdoni.io/dvote/vochain/keykeeper.(*KeyKeeper).Commit.func1()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/tree/arbo/navigate.go:82 +0xc64
testsuite_7000208867-miner3-1    |       go.vocdoni.io/dvote/vochain/keykeeper/keykeeper.go:243 +0x3e
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/tree/arbo.(*Tree).GetWithTx()
testsuite_7000208867-miner3-1    | 
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/tree/arbo/tree.go:541 +0x789
testsuite_7000208867-miner3-1    | Previous write at 0x00c00a2e4000 by goroutine 255:
testsuite_7000208867-miner2-1    |   go.vocdoni.io/dvote/tree.(*Tree).Get()
testsuite_7000208867-miner2-1    |       go.vocdoni.io/dvote/tree/tree.go:70 +0x144

https://github.com/vocdoni/vocdoni-node/actions/runs/7000208867/job/19040533596#step:4:8191

[coveralls]

Pull Request Test Coverage Report for Build 7004589708

• 40 of 79 (50.63%) changed or added relevant lines in 1 file are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.01%) to 61.667%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cmd/end2endtest/account.go	40	79	50.63%

Files with Coverage Reduction	New Missed Lines	%
cmd/end2endtest/account.go	4	66.31%

Totals
Change from base Build 6983696410:	0.01%
Covered Lines:	14675
Relevant Lines:	23797

---

💛 - Coveralls