Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: SIKFromAddress data race #1199

Merged
merged 2 commits into from
Nov 23, 2023
Merged

bug: SIKFromAddress data race #1199

merged 2 commits into from
Nov 23, 2023

Conversation

lucasmenendez
Copy link
Contributor

Fixes #1197

@lucasmenendez lucasmenendez added the bug Something isn't working label Nov 23, 2023
@lucasmenendez lucasmenendez self-assigned this Nov 23, 2023
@lucasmenendez lucasmenendez linked an issue Nov 23, 2023 that may be closed by this pull request
SIKFromAddress data race #1197
Closed
@coveralls
Copy link

coveralls commented Nov 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6972289246

  • 24 of 28 (85.71%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 61.766%
Changes Missing Coverage Covered Lines Changed/Added Lines %
vochain/state/sik.go 22 26 84.62%
Files with Coverage Reduction New Missed Lines %
data/ipfs/ipfs.go 2 52.98%
vochain/indexer/archive.go 2 80.58%
vochain/state/sik.go 3 80.47%
Totals Coverage Status
Change from base Build 6944527117: 0.1%
Covered Lines: 14644
Relevant Lines: 23709
💛 - Coveralls

@lucasmenendez
Copy link
Contributor Author

@p4u do you think that is enough by using the treeTxWithMutex instead of atomic.Pointer[statedb.TreeView]?

Check also the test, please!

@lucasmenendez lucasmenendez marked this pull request as ready for review November 23, 2023 15:01
p4u
p4u approved these changes Nov 23, 2023
View reviewed changes
vochain/state/sik.go Outdated Show resolved Hide resolved
@lucasmenendez lucasmenendez merged commit 101d965 into main Nov 23, 2023
20 checks passed
@lucasmenendez lucasmenendez deleted the bug/sikfromaddress_data_race branch November 23, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4u p4u p4u approved these changes

Assignees

@lucasmenendez lucasmenendez

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIKFromAddress data race
3 participants
@lucasmenendez @coveralls @p4u