Created @vocdoni/react-providers #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've removed vite in favor of tsup because I've not been able to make work the bundles generated by vite properly (all I tried was causing context errors). But everything related to bundling now works better: - Now ts files are used as entry points, meaning you won't need to run `yarn build` in a package when developing and trying stuff in other packages. - These ts files are now replaced on prepack using the clean-package package. - The resulting npmjs package ends up being the same as it's now, a properly bundled bundle of js files I also had to reconsider how we were treating dependencies in some packages. The functionality is the same, we'll need to install react-markdown and its dependency because it's left as peerDependency. This is done this way because in the future we should try to set this dependency as optional (only enable markdown rendering if it is installed and detected). rainbow-wallets should also be updated to use tsup, so it follows the same principles as the other packages, and also so we can import it without bundling issues. refs #79
…lthough they weren't required)
elboletaire
force-pushed
the
f/react-providers-79
branch
from
1b51b92
to
189b16d
Compare
|
I may break things but... let's give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed vite in favor of tsup because I've not been able to make work the bundles generated by vite properly (all I tried was causing context errors).
But everything related to bundling now works better:
yarn buildin a package when developing and trying stuff in other packages.I also had to reconsider how we were treating dependencies in some packages. The functionality is the same, we'll need to install react-markdown and its dependency because it's left as peerDependency. This is done this way because in the future we should try to set this dependency as optional (only enable markdown rendering if it is installed and detected).
closes #79