Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: arbo verifier with generic hash function #2

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

lucasmenendez
Copy link
Collaborator

Now the arbo verifier admits a hash function as a parameter. This allows to switch the hash function implementations and also over different curves.

  • Tests with poseidon over bn254 and mimc7 over bls12_377 (but can be used over all curves supported by gnark).

@lucasmenendez lucasmenendez added the enhancement New feature or request label Nov 18, 2024
@lucasmenendez lucasmenendez self-assigned this Nov 18, 2024
Copy link
Member

@p4u p4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

arbo/verifier_bls12377_test.go Outdated Show resolved Hide resolved
arbo/verifier_bls12377_test.go Outdated Show resolved Hide resolved
arbo/utils.go Outdated Show resolved Hide resolved
arbo/hints.go Outdated Show resolved Hide resolved
@lucasmenendez
Copy link
Collaborator Author

@p4u I would like to merge this PR after merging the arbo PR to include the final dependency in this one.

@lucasmenendez lucasmenendez merged commit 5bccb51 into main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants