Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/body parser #96

Merged
merged 4 commits into from
Dec 18, 2022
Merged

Fix/body parser #96

merged 4 commits into from
Dec 18, 2022

Conversation

noctera
Copy link
Member

@noctera noctera commented Dec 4, 2022

Status Type Env Vars Change
✅ Ready Bug Yes

Description

This PR will fix issue vocascan/vocascan-frontend#142 to support custom file upload sizes.

just add the following property in you vocascan.config.js

server: {
    ...
    max_file_upload: '1mb', // 1kb, 1mb, 1gb
 },

I have added this variable setting to the /info route to make the value accessible for the client (more specific error messages)

Motivation and Context

Without this setting you couldn't import much vocabs, as the default limit was very small

Screenshots / GIFs (if appropriate):

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

vocascan/vocascan-fronten#142

@noctera noctera added kind/bug Something isn't working kind/dependencies Pull request that updates a dependency file kind/api priority/medium labels Dec 4, 2022
@noctera noctera added this to the v1.4.0 milestone Dec 4, 2022
@noctera noctera requested a review from luwol03 December 4, 2022 11:44
@noctera noctera self-assigned this Dec 4, 2022
app/config/config/schema.js Outdated Show resolved Hide resolved
@noctera noctera changed the base branch from main to experimental December 4, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api kind/bug Something isn't working kind/dependencies Pull request that updates a dependency file priority/medium
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

2 participants