Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/activate refactor #145

Merged
merged 12 commits into from
Feb 26, 2023
Merged

Feat/activate refactor #145

merged 12 commits into from
Feb 26, 2023

Conversation

noctera
Copy link
Member

@noctera noctera commented Dec 4, 2022

Status Type
✅ Ready Feature

Description

This PR will add a new way to activate staged vocabs, giving the ability to activate specific groups and not all at once

Demo:

2022-12-04.13-39-44.mp4

In addition to this I have done a basic implementation of the custom learning tab, giving you the ability to start queries, apart from your daily query, that don't count into your statistics. In this tab you can select between all vocabs from a group (including unactivated) or only activated vocabs (excluding unactivated) vocabs

Demo:

2022-12-04.13-43-29.mp4

Motivation and Context

This functions will give the user more freedom in activating and learning vocabs

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

#132
#126

@noctera noctera added kind/enhancement New feature or request kind/ui UI changes priority/medium labels Dec 4, 2022
@noctera noctera added this to the v1.4.0 milestone Dec 4, 2022
@noctera noctera requested a review from luwol03 December 4, 2022 12:48
@noctera noctera self-assigned this Dec 4, 2022
@noctera noctera changed the base branch from main to experimental December 17, 2022 12:37
Copy link
Member

@luwol03 luwol03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@noctera noctera merged commit 45e49df into experimental Feb 26, 2023
@noctera noctera deleted the feat/activate-refactor branch February 26, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/ui UI changes priority/medium
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

2 participants