Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task IAC-807] Enable Collecting Hints from vRO and Local Actions / Modules #144

Merged

Conversation

akantchev
Copy link
Contributor

Description

When trying to invoke hinting for module System.getModule("module.path") or Class.load("class.path") it does not fetch the actions from the configured vRO instance and does not show any hints methods / actions for the module.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have tested against live vRO/vRA, if applicable
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Open a java script action and try to write

System.getModule("com.module.path.").

or

Class.load("com.module.path.").

or

VcVirtualMachine.

It should be possible to fetch a list of modules (within the string literal) and actions / methods in the instance, that are displayed as lists. The class path can be either local or stored as an action in vRO.

Release Notes

  • Enable hinting on vRO and locally loaded modules / actions.

@akantchev akantchev requested a review from a team as a code owner April 10, 2024 12:27
@vmwclabot
Copy link
Member

@akantchev, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Merging #144 (7f76ca5) into master (165c9db) will increase coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 7f76ca5 differs from pull request most recent head a27c569. Consider uploading reports for the commit a27c569 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   54.21%   54.35%   +0.13%     
==========================================
  Files          40       40              
  Lines         806      804       -2     
  Branches      117      116       -1     
==========================================
  Hits          437      437              
+ Misses        331      330       -1     
+ Partials       38       37       -1     

@@ -134,6 +134,7 @@ export class ServerCollection {
collectObjects() {
this.getVroObjects()
.then(objects => {
// todo merge both in same actions.pb file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this todo for now and discuss it offline

@vmwclabot
Copy link
Member

@akantchev, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Alexander Kantchev <[email protected]>
@vmwclabot
Copy link
Member

@akantchev, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@VenelinBakalov VenelinBakalov merged commit dc5cc5f into master Apr 11, 2024
13 checks passed
@VenelinBakalov VenelinBakalov deleted the IAC-807-improve-js-hinting-plugin-data-collection branch April 11, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants