dnat: allow different src/translated port

[Boran]

Initial issue
"vcd_dnat missing separate original and translated port in vCloud Director provider"
hashicorp/terraform#12384

Added a new (optional) param translated_port, keeping the existing port as the src port.
If translated_port is not specified use port - allows backward compatibility.
The name translated_port was selected because it is closer to the api and is less confusing than internal/external for example.

Based on PR for terraform hashicorp/terraform#14437, now in a separate provider repo.

The corresponding issue in govair is vmware-archive/govcloudair#37 and UKCloud/govcloudair#3

[bobbydeveaux]

Thanks @Boran - I have the ability to merge now, but just sorting out the tests so that we can run the full suite including PR against UKCloud infrastructure and check all acceptance tests pass etc. Working on that right now!

[Boran]

Great.
I compiled TF 0.10 locally and am trying to get it to load the patched vcd provider, but haven't figured it out, is it not just a question of adding to .terraformrc?
providers {
vcd = "/Users/me/gocode/bin/terraform-provider-vcd"
}
Any suggestions?

[bobbydeveaux]

@Boran - with 0.10 you need to build the provider separately. Once you've ran, 'make build' - it will run 'go install' and place terraform-provider-vcd in the GOPATH/bin folder.

You then need to run:

terraform init

That will load the provider for you to use :)

[Boran]

Sure I did that, but it is not finding it. Which is why I created the .terraformrc.
I found the reason though: terraform has also been copied to /usr/local/bin and when it ran from there it expected the provider to be in the same directory.

[bobbydeveaux]

Hi @Boran - I now have tests passing on the master branch in HashiCorp's CI environment. Just looking at the best way to run the full suite against this pull request. Once that's sorted we should be a strong position to move things forward much more quickly in future! :)

[Boran]

Excellent, thanks for your work!

[bobbydeveaux]

@Boran - happy days - all 9 tests passed. Merging.

OK TestAccVcdVAppVm_Basic 10m:05s,879ms 9
OK TestAccVcdVApp_PowerOff 7m:39s,151ms 8
OK TestAccVcdVAppRaw_Basic 6m:23s,359ms 7
OK TestAccVcdFirewallRules_basic 2m:27s,984ms 4
OK TestAccVcdSNAT_Basic 2m:15s,679ms 6
OK TestAccVcdVpn_Basic 2m:14s,552ms 3
OK TestAccVcdNetwork_Basic 2m:11s,087ms 5
OK TestAccVcdDNAT_tlate 2m:05s,011ms 2
OK TestAccVcdDNAT_Basic 1m:59s,093ms 1