Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

650: Fix issue with CSI manifests for v1.6.0 #663

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

arunmk
Copy link
Collaborator

@arunmk arunmk commented Oct 7, 2024

Description

Please provide a brief description of the changes proposed in this Pull Request

  • CSI manifests are not updated for CSI-1.6.0 which brings in volume expansion and block support. This change updates the manifests to have the same RBAC and support containers that are present in the CSI 1.6.0 release.
    Fixes csi-controller-crs command error with v.1.6.0 #650

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

volume expansion and block support. This change updates the manifests
to have the same RBAC and support containers that are present in
the CSI 1.6.0 release.
@arunmk arunmk changed the title 275: Fix issue with CSI manifests for v1.6.0 650: Fix issue with CSI manifests for v1.6.0 Oct 7, 2024
Copy link
Contributor

@ymo24 ymo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lzichong and @sakthisunda)

Copy link
Contributor

@sakthisunda sakthisunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lzichong)

@arunmk arunmk merged commit 4c7a7cf into vmware:1.3.z Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants