Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove containerd proxy config #356

Closed
wants to merge 1 commit into from

Conversation

bavarianbidi
Copy link

@bavarianbidi bavarianbidi commented Nov 29, 2022

as we do the containerd proxy config via kubeadm and the build-in config overwrite our own config we have to remove it.

Signed-off-by: Mario Constanti [email protected]

towards #299

Description

This PR removes the containerd proxy configuration from the built-in cloud-init scripts.

Open ToDos:

  • remove proxy configuration from vcdcluster.spec

  • provide a template example and document the usage behind a proxy

Checklist

  • tested locally
  • updated any relevant dependencies
  • updated any relevant documentation or examples

API Changes

Are there API changes?

  • Yes
  • No

If yes, please fill in the below

  1. Updated conversions?
    • Yes
    • No
    • N/A
  2. Updated CRDs?
    • Yes
    • No
    • N/A
  3. Updated infrastructure-components.yaml?
    • Yes
    • No
    • N/A
  4. Updated ./examples/capi-quickstart.yaml?
    • Yes
    • No
    • N/A
  5. Updated necessary files under ./infrastructure-vcd/v1.0.0/?
    • Yes
    • No
    • N/A

Issue

If applicable, please reference the relevant issue

Fixes #


This change is Reviewable

as we do the containerd proxy config via kubeadm and the build-in
config overwrite our own config we have to remove it.

Signed-off-by: Mario Constanti <[email protected]>
@arunmk
Copy link
Collaborator

arunmk commented Jan 5, 2023

@bavarianbidi there are a couple of comments here:

  1. We do need to run conversion-gen and get the updated files.
  2. suppose there is a cluster with proxy already set-up using the variables. When they move to the system that you have mentioned, those variables will need to be converted to the new variables above. Those would have to be added to the conversion-gen.

@erkanerol
Copy link
Contributor

@bavarianbidi We talked about this issue with @arunmk He doesn't want to remove proxy support from VCDCluster spec. I opened a PR, that adds proxy configuration to cloud_init script when only proxy settings are not empty. #395

I think we can close this PR.

@bavarianbidi
Copy link
Author

close in favor of #395

@erkanerol erkanerol deleted the remove_proxy_config branch July 11, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants