🐛 VM Watcher Service improvements #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
force-pushed
the
bryanv/async-watch-with-stale-foilder-moids
branch
3 times, most recently
from
d0ff0f0 to
492a69a
Compare
When building the initial container MoID list, include the IDs so that we can match the Add() and Remove() of the same ID. We had a bug here in that if the Zone was initially added to a NS when at start up time, any later removal of the Zone from a NS would remove the watch of that Zone across all namespaces. This allows the watcher Add() and Remove() to be idempotent which is needed for some infra Zone controller described later. Tweak how the infra Zone controller handles the finalizer. The VC watcher itself is ephemeral since it will go away when the VC client is closed. But we need the Zone finalizer so that we can remove it from the watcher when the Zone goes away. Therefore, call Add() or Remove() on the Zone regardless if the finalizer was already present or not. Better handle a Zone with a stale FolderMoID: if a folder does not exist on VC, the watcher will fail to start. We filter out invalid container MoIDs to the watcher; the Zone controller will later keep retrying to add that FolderMoID to the watcher. Much of change is fallout from 14c1ac3 when we changed the VM watcher service to not os.Exit() whenever the watcher could not be started.
bryanv
force-pushed
the
bryanv/async-watch-with-stale-foilder-moids
branch
from
492a69a to
d03b453
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
When building the initial container MoID list, include the IDs so that we can match the Add() and Remove() of the same ID. We had a bug here in that if the Zone was initially added to a NS when at start up time, any later removal of the Zone from a NS would remove the watch of that Zone across all namespaces. This allows the watcher Add() and Remove() to be idempotent which is needed for some infra Zone controller described later.
Tweak how the infra Zone controller handles the finalizer. The VC watcher itself is ephemeral since it will go away when the VC client is closed. But we need the Zone finalizer so that we can remove it from the watcher when the Zone goes away. Therefore, call Add() or Remove() on the Zone regardless if the finalizer was already present or not.
Better handle a Zone with a stale FolderMoID: if a folder does not exist on VC, the watcher will fail to start. We filter out invalid container MoIDs to the watcher; the Zone controller will later keep retrying to add that FolderMoID to the watcher.
Much of change is fallout from 14c1ac3 when we changed the VM watcher service to not os.Exit() whenever the watcher could not be started.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: