🐛 Background reconcile awareness support #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
fix/do-not-reconcile-in-progress-items
branch
from
e66aeff to
b4c8021
Compare
github-actions
bot
added
size/L
akutz
force-pushed
the
fix/do-not-reconcile-in-progress-items
branch
2 times, most recently
from
492155c to
f1e0697
Compare
This patch adds support to the VirtualMachine controller for background reconciliation awareness. Rather, the controller is now aware if a VM is already being reconciled in a background thread due to an async operation and will not allow the VM to be reconciled again until the async operation is complete.
akutz
force-pushed
the
fix/do-not-reconcile-in-progress-items
branch
from
f1e0697 to
469de67
Compare
Minimum allowed line rate is |
bryanv
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch adds support to the VirtualMachine controller for background reconciliation awareness. Rather, the controller is now aware if a VM is already being reconciled in a background thread due to an async operation and will not allow the VM to be reconciled again until the async operation is complete.
This is necessary due to someone rapidly applying VM yaml then deleting it. When this occurs it is possible that the vSphere VM is not deleted since its creation is occurring on a background thread.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: