Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose VSC SourceVolumeMode 1.14 #8280

Merged

Conversation

msfrucht
Copy link
Contributor

@msfrucht msfrucht commented Oct 8, 2024

Thank you for contributing to Velero!

Cherry-pick of #8261 as requested for Velero 1.14.

Please add a summary of your change

Copies the VolumeSnapshotContent SourceVolumeMode during DataUpload. Recent versions of the snapshot-controller do not allow the field to be changed from "Filesystem" or "Block" to nil resulting in a failure to move the VolumeSnapshot into the local namespace.

This was found in Kubernetes 1.29/OpenShift 4.16

@shubham-pampattiwar identified the underlying source of the behavior changes to https://kubernetes.io/blog/2024/04/30/prevent-unauthorized-volume-mode-conversion-ga/ and shows up in external-provisioner v4.0.0 and external-snapshotter v7.0.0.

This field is typically nil to begin with in other environments which doesn't trigger this error.

Does your change fix a particular issue?

Fixes #(issue)
#8259

Please indicate you've done the following:

@msfrucht msfrucht force-pushed the copy_sourcevolumemode_1.14 branch 2 times, most recently from 0cc98d2 to c1dc8b0 Compare October 8, 2024 20:11
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.73%. Comparing base (4a86f28) to head (8f037f2).
Report is 2 commits behind head on release-1.14.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.14    #8280   +/-   ##
=============================================
  Coverage         58.73%   58.73%           
=============================================
  Files               346      346           
  Lines             28840    28841    +1     
=============================================
+ Hits              16940    16941    +1     
  Misses            10471    10471           
  Partials           1429     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add changelog and unittest

Signed-off-by: Michael Fruchtman <[email protected]>
Signed-off-by: MICHAEL S FRUCHTMAN <[email protected]>
@msfrucht msfrucht marked this pull request as ready for review October 8, 2024 21:08
@Lyndon-Li Lyndon-Li merged commit 2636f5b into vmware-tanzu:release-1.14 Oct 11, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants