Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional unit test for expose log with TANZU_CLI_LOG_LEVEL #85

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Jul 31, 2023

What this PR does / why we need it

Add additional unit test based on the review comments: #83

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  • Run unit tests as part of CI

Release note

None

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner July 31, 2023 16:30
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving this.

@anujc25 anujc25 merged commit ce40415 into vmware-tanzu:main Jul 31, 2023
4 checks passed
marckhouzam pushed a commit to marckhouzam/tanzu-plugin-runtime that referenced this pull request Jul 31, 2023
@marckhouzam marckhouzam added this to the v1.0.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants