Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect base64 encoded caCert usage with Hub Client #212

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Aug 30, 2024

What this PR does / why we need it

  • Fix incorrect base64 encoded caCert usage with Hub Client

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

None

Additional information

Special notes for your reviewer

client/hub/client.go Outdated Show resolved Hide resolved
client/hub/client.go Outdated Show resolved Hide resolved
client/hub/client.go Outdated Show resolved Hide resolved
client/hub/client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few typos, lgtm, thanks!

@anujc25 anujc25 merged commit 16326a5 into vmware-tanzu:main Aug 30, 2024
4 checks passed
anujc25 added a commit to anujc25/tanzu-plugin-runtime that referenced this pull request Aug 30, 2024
anujc25 added a commit that referenced this pull request Aug 30, 2024
@marckhouzam marckhouzam added this to the v1.4.3 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants