Before PR merging, run advance e2e test #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only run basic e2e test(e2e_test) for every commit. Now we need this: after all comments on PR are solved and just before merging, we should run advance e2e test(byohost_reuse_test+md_scale_test), and we should manually trigger this workflow for that.
In order to achieve this, I create a new tag "ready-for-merge". After all comments are solved, please tag the PR with this new tag, the advance e2e test will be kickoff. Merge this PR only after the advance e2e test are passed
Signed-off-by: chen hui [email protected]