Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

WIP: Initial move of the certificate chain tree rendered with compact… #413

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iilieva
Copy link
Contributor

@iilieva iilieva commented Feb 28, 2022

… cert details display.

Note: datejs has been chosen to replace the momnentjs logic, since we are using basic functionality from the momentjs.
For our current use cases, is is preffered over luxon, which is much more robust.

Unit tests and Live doc examples should be added.

Testing Done: TBD

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Examples have been added / updated (for bug fixes / features)
  • Changelog has been updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Example website changes
  • Version bump
  • Other... Please describe:

What does this change do?

What manual testing did you do?

Screenshots (if applicable)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

… cert details display.

Note: datejs has been chosen to replace the momnentjs logic, since we are using basic functionality from the momentjs.
For our current use cases, is is preffered over luxon, which is much more robust.

Unit tests and Live doc examples should be added.

Testing Done: TBD
@vmwclabot
Copy link

@iilieva, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #413 (e3adad2) into master (1fd62ed) will decrease coverage by 3.17%.
The diff coverage is 35.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   86.92%   83.75%   -3.18%     
==========================================
  Files         106      110       +4     
  Lines        3456     3680     +224     
  Branches      542      569      +27     
==========================================
+ Hits         3004     3082      +78     
- Misses        300      446     +146     
  Partials      152      152              
Impacted Files Coverage Δ
...ponents/src/utils/certificate/human-certificate.ts 22.22% <22.22%> (ø)
...nts/src/utils/certificate/certificate-processor.ts 35.67% <35.67%> (ø)
...ojects/components/src/common/pipes/no-info.pipe.ts 40.00% <40.00%> (ø)
...mponents/src/utils/certificate/certificate-util.ts 42.85% <42.85%> (ø)
...ojects/components/src/common/pipes/pipes.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd62ed...e3adad2. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants