[CHORE] proxy status of test to travis (#2461)

also fixed some lint errors showing up right now that snuck into master due to this bug

Signed-off-by: Jeremy Wilken <[email protected]>

scripts/travis.js

@@ -33,7 +33,11 @@ if (
   process.env.TRAVIS_BRANCH === 'master'
 ) {
   shell.exec(`npm install ${AngularPackages.join(' ')} --no-save`);
-  shell.exec('npm run $TEST_SUITE');
+  if (shell.exec('npm run $TEST_SUITE').code !== 0) {
+    shell.exit(1);
+  }
 } else {
-  shell.exec('npm run $TEST_SUITE');
+  if (shell.exec('npm run $TEST_SUITE').code !== 0) {
+    shell.exit(1);
+  }
 }

src/clr-angular/button/button-loading/loading-button.spec.ts

@@ -60,17 +60,17 @@ describe('Loading Buttons', () => {
       fixture.componentInstance.buttonState = ClrLoadingState.LOADING;
       fixture.detectChanges();
       expect(fixture.componentInstance.buttonState).toEqual(ClrLoadingState.LOADING);
-      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes['disabled']).toBeTruthy();
+      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes.disabled).toBeTruthy();
 
       fixture.componentInstance.buttonState = ClrLoadingState.SUCCESS;
       fixture.detectChanges();
       expect(fixture.componentInstance.buttonState).toEqual(ClrLoadingState.SUCCESS);
-      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes['disabled']).toBeTruthy();
+      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes.disabled).toBeTruthy();
 
       tick(1000);
       fixture.detectChanges();
       expect(fixture.componentInstance.buttonState).toEqual(ClrLoadingState.DEFAULT);
-      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes['disabled']).toBeTruthy();
+      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes.disabled).toBeTruthy();
 
       // now the input binding sets the disabled to false
       // it should be disabled while loading, and success, but change back to not disabled when it goes back to DEFAULT
@@ -80,17 +80,17 @@ describe('Loading Buttons', () => {
       fixture.componentInstance.buttonState = ClrLoadingState.LOADING;
       fixture.detectChanges();
       expect(fixture.componentInstance.buttonState).toEqual(ClrLoadingState.LOADING);
-      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes['disabled']).toBeTruthy();
+      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes.disabled).toBeTruthy();
 
       fixture.componentInstance.buttonState = ClrLoadingState.SUCCESS;
       fixture.detectChanges();
       expect(fixture.componentInstance.buttonState).toEqual(ClrLoadingState.SUCCESS);
-      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes['disabled']).toBeTruthy();
+      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes.disabled).toBeTruthy();
 
       tick(1000);
       fixture.detectChanges();
       expect(fixture.componentInstance.buttonState).toEqual(ClrLoadingState.DEFAULT);
-      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes['disabled']).toBeFalsy();
+      expect(fixture.componentInstance.loadingButtonInstance.el.nativeElement.attributes.disabled).toBeFalsy();
     })
   );
 

src/clr-angular/button/button-loading/loading-button.ts

@@ -65,7 +65,7 @@ export class ClrLoadingButton implements LoadingListener {
   constructor(public el: ElementRef, private renderer: Renderer2) {}
 
   loadingStateChange(state: ClrLoadingState): void {
-    if (state == this.state) {
+    if (state === this.state) {
       return;
     }
     this.state = state;