-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Add uninitialized params tracking for AutoWeightsLoader
#10327
Conversation
Signed-off-by: Isotr0py <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the QoL improvement!
Hmm. not sure whether we're being too strict or is the weight loader buggy? |
Signed-off-by: Isotr0py <[email protected]>
Hmmm, seems that Perhaps we should add the loading check on top of |
Agreed, let's move the weight loading check to a higher level. |
Signed-off-by: Isotr0py <[email protected]>
Since we may skip loading some layers in vision models / PP case, we should update the check to error out when weights inside the initialized model aren't loaded, rather than when some weights from the checkpoint aren't loaded. |
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
…m-project#10327) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
Currently, model have uninitialized parameters won't raise any error even a warning message. This makes some bugs like #10297 (comment) and #9422 (comment) caused by incorrect weights loading/model initialization difficult to be found.
AutoWeightsLoader
.