Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add uninitialized params tracking for AutoWeightsLoader #10327

Merged
merged 28 commits into from
Nov 18, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 14, 2024

Currently, model have uninitialized parameters won't raise any error even a warning message. This makes some bugs like #10297 (comment) and #9422 (comment) caused by incorrect weights loading/model initialization difficult to be found.

  • Add feature to track uninitialized weights for AutoWeightsLoader.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py marked this pull request as draft November 14, 2024 13:48
@DarkLight1337 DarkLight1337 self-assigned this Nov 14, 2024
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Copy link

mergify bot commented Nov 15, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Isotr0py.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 15, 2024
@mergify mergify bot removed the needs-rebase label Nov 16, 2024
@Isotr0py Isotr0py marked this pull request as ready for review November 16, 2024 14:45
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 17, 2024 09:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 17, 2024
@DarkLight1337
Copy link
Member

Hmm. not sure whether we're being too strict or is the weight loader buggy?

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Nov 17, 2024

Hmmm, seems that strict=True is too strict for sharded safetensors, because in that case the weights of a module will be sharded into multiple files. It will trigger strict check then raise error while the module is partially loaded from one of the shared files...

Perhaps we should add the loading check on top of DefaultModelLoader in loader.py instead of AutoWeightsLoader.

@DarkLight1337
Copy link
Member

Agreed, let's move the weight loading check to a higher level.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 17, 2024

Since we may skip loading some layers in vision models / PP case, we should update the check to error out when weights inside the initialized model aren't loaded, rather than when some weights from the checkpoint aren't loaded.

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 DarkLight1337 merged commit c4e4643 into vllm-project:main Nov 18, 2024
50 checks passed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 18, 2024
@Isotr0py Isotr0py deleted the track-weight-load branch November 18, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants