Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] TPU Prototype #10241

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Nov 12, 2024

SUMMARY:

  • prototyping TPU on vLLM V1
  • correctness pytest -s tests/entrypoints/openai/test_accuracy.py::test_lm_eval_accuracy_v1_engine
  • nice speedups for cpu intensive workload vs V0 (33% on Qwen-1.5B on tpuv5e for sharegpt)

TODOS:

  • refactor to share abstractions with GPU
  • support sampling
  • support prefix caching
  • support naive chunked prefill
  • harden testing
  • tp > 1 (wait for tyler's PR first)

LONG TERM TODO:

  • get a true variable length append kernel to enable chunked prefill

BENCHMARKS:

export MODEL=Qwen/Qwen2.5-1.5B-Instruct
  • VLLM_USE_V1=1 , VLLM_ENABLE_V1_MULTIPROCESSING=1
VLLM_ENABLE_V1_MULTIPROCESSING=1 VLLM_USE_V1=1 python3 benchmarks/benchmark_throughput.py --model $MODEL --dataset benchmarks/ShareGPT_V3_unfiltered_cleaned_split.json --max-model-len 2048

# Throughput: 27.81 requests/s
  • VLLM_USE_V1=1, VLLM_ENABLE_V1_MULTIPROCESSING=0
VLLM_ENABLE_V1_MULTIPROCESSING=0 VLLM_USE_V1=1 python3 benchmarks/benchmark_throughput.py --model $MODEL --dataset benchmarks/ShareGPT_V3_unfiltered_cleaned_split.json --max-model-len 2048

# Throughput: 25.98 requests/s
  • VLLM_USE_V1=0
VLLM_USE_V1=0 python3 benchmarks/benchmark_throughput.py --model $MODEL --dataset benchmarks/ShareGPT_V3_unfiltered_cleaned_split.json --max-model-len 2048

# Throughput: 20.87 requests/s

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant