-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor + new features (conditional, repeated sink paths, collection source, generator settings) #58
Conversation
Tests coverage table for d93e00c commit.
|
@@ -1,7 +1,7 @@ | |||
TEST_PATH = ./tests/ | |||
FLAKE8_EXCLUDE = venv,.venv,.eggs,.tox,.git,__pycache__,*.pyc | |||
PROJECT = pysubyt | |||
AUTHOR = Marc_Portier | |||
AUTHOR = Vlaams Instituut voor de Zee (VLIZ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be open science vliz
@@ -27,6 +27,7 @@ jinja2 = "*" | |||
pyrdfj2 = "*" | |||
furo = "*" | |||
recommonmark = "*" | |||
pandas = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a convention stating that we limit ourselves to the latest mayor version of a package eg: 4.x.x ? This to prevent later failures with other library implementations.
I removed myself as a reviewer since I don't think I can provide any meaningful review at this point. I may have some ideas for the testing part, which falls a bit outside the context of this PR, I think. |
implements #52