Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor + new features (conditional, repeated sink paths, collection source, generator settings) #58

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

bulricht
Copy link
Contributor

@bulricht bulricht commented Mar 13, 2024

implements #52

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Tests coverage table for d93e00c commit.

pycoverage

Name Stmts Miss Cover Missing
pysubyt/api.py 138 3 97.83% 159 351 355
pysubyt/j2/generator.py 17 0 100.0%
pysubyt/sinks.py 90 13 85.56% 19 33-34 38 42 55 58 61 64 67 77 80 113
pysubyt/sources.py 215 22 89.77% 26 70-77 92-93 125 240 245-246 277 288 291-292 323 330
pysubyt/subyt.py 18 0 100.0%
TOTAL 478 38 92.05%

@@ -1,7 +1,7 @@
TEST_PATH = ./tests/
FLAKE8_EXCLUDE = venv,.venv,.eggs,.tox,.git,__pycache__,*.pyc
PROJECT = pysubyt
AUTHOR = Marc_Portier
AUTHOR = Vlaams Instituut voor de Zee (VLIZ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be open science vliz

@@ -27,6 +27,7 @@ jinja2 = "*"
pyrdfj2 = "*"
furo = "*"
recommonmark = "*"
pandas = "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a convention stating that we limit ourselves to the latest mayor version of a package eg: 4.x.x ? This to prevent later failures with other library implementations.

@jorgecunhamendes jorgecunhamendes removed their request for review March 18, 2024 08:35
@jorgecunhamendes
Copy link

I removed myself as a reviewer since I don't think I can provide any meaningful review at this point. I may have some ideas for the testing part, which falls a bit outside the context of this PR, I think.

@bulricht bulricht merged commit 4ddc2a2 into main Mar 26, 2024
2 checks passed
@bulricht bulricht deleted the refactor branch March 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants