Style management changes #566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcqls what do you think? |
I'll have a look very soon.... |
squidink7
force-pushed
the
theme_management
branch
2 times, most recently
from
078abad
to
be4df07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the way styles are handled by controls throughout the window.
The initial motivation was to add a simple way to switch themes at runtime, which in itself was simple enough but I wanted a way to allow individual widgets to have their own style rather than overriding them all each time the window's theme changed.
This makes it so each widget's
theme_stylefield is empty unless explicitly set, and when rendering it uses the theme set on the window unless otherwise specified.Previously V UI set the
theme_styleacross all widgets when the window is created.I haven't thoroughly tested each example yet, and in absence of unit tests have been basing this work on a sample app of my own which doesn't use anywhere near every control available, so oversights may be present. I apologise if any have slipped through.