custom shell setting unimplemented, not viable

DjangoCommands.sublime-settings

@@ -19,8 +19,6 @@
     "linux_terminal": "x-terminal-emulator",
     // Mac OSX only: define your preferred_terminal_emulator
     "osx_terminal": "Terminal",
-    // Shell
-    "shell_executable": "bash",
     // Per project setting "python_interpreter" overrides "python_bin"
     "project_override": true,
     // Open browser pointint to root url after runserver command

README.md

@@ -116,10 +116,8 @@ Currently supports following commands:
  * `server_port`: port for the server to listen
  * `linux_terminal`: Linux only, used to define a custom command line emulator\*\*
  * `osx_terminal`: Mac OSX only, used to define a custom terminal emulator.\*\*\*
- * `shell_executable`: For OSX and Linux, set your preferred shell for the commands to be launched in.
  * `browser_after_runserver`: set true to open a browser pointing to the root url after a run server command.
  * `project_override`: (Boolean) Per project setting "python_interpreter" overrides "python_bin"
-
  * `server_custom_command`: Per project setting to specify a custom server to run
 
 ***
@@ -132,7 +130,7 @@ Currently supports following commands:
 
 \*\*Default is `x-terminal-emulator` with a fallback to `xterm`
 
-\*\*\*Default is "Terminal"
+\*\*\*Default is `Terminal`
 
 ### Please report any issue, bug, enhacement or comment [here](https://github.com/vladimirnani/DjangoCommands/issues) 
 ### We'll be glad to read and work on all of them

django-commands.py

@@ -79,14 +79,6 @@ def get_version(self, extb=None):
             version = re.match(r'(\d\.\d+)', output.decode('utf-8')).group(0)
             return version
 
-    def get_shell(self):
-        shell = self.settings.get('shell_executable', 'bash')
-        if not os.access(shell, os.X_OK):
-            self.error_msg = "{} not found. Bash will be used as a fallback".format(shell)
-            self.display_error_message()
-            shell = 'bash'
-        return shell
-
     def find_manage_py(self):
         django_project_root = \
             sublime.active_window().active_view().settings().get('django_project_root') \
@@ -433,8 +425,7 @@ def run(self):
         if PLATFORM == 'Windows':
             command = ['cmd', '/k', '{}'.format(os.path.join(bin_dir, self.command))]
         if PLATFORM == 'Linux' or PLATFORM == 'Darwin':
-            command = [self.get_shell(),
-                       "--rcfile", "<(echo '. ~/.bashrc && . {}')".format(os.path.join(bin_dir, self.command))]
+            command = ["bash", "--rcfile", "<(echo '. ~/.bashrc && . {}')".format(os.path.join(bin_dir, self.command))]
         thread = CommandThread(command, notsplit=True)
         thread.start()
 

messages/important.md

@@ -8,8 +8,8 @@ Django manage commands 1.7.9
 
  - Mac OSX users now can select their preferred terminal emulator to be triggered to run the corresponding command. Use `osx_terminal` setting.
 
- - Linux and Mac OSX now can define their preferred shell to run commands in. E.g: Bash, Zsh, Fish, etc. It will be checked that the shell executable exists and its accesible and, if not, will fallback to bash.
-
  - Windows users, would you like to be able to select another terminal instead of cmd.exe like mintty, cmder or git-bash? If so please open an Issue(only one please so others can comment on it, and keep the issue tracker organized) at our github repo and let us know.
 
- - Minor fixes and performance optimizations.
+ - Windows slight performance optimization.
+
+ - Minor fixes.