-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing the port in the healthcheck for the minidlna image #247
Conversation
This will not work because it will try to parse an |
Hmm from what i readi i am not sure but answer is likely no change need be done or double $ (for compose solution i read that answer is $$) |
Can you please change your code to this: HEALTHCHECK --interval=10s --timeout=10s --retries=6 CMD \
curl --silent --fail 127.0.0.1:"${MINIDLNA_PORT:-8200}" || exit 1 I have done some tests, and it seems to work. I will merge it after you change it. |
Sure. Great that it is working straightforward. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Happy to help |
Not tested but i believe this may fix healthcheck
details: #246