Skip to content

Commit

Permalink
Rename samba_disable_netbios to samble_enable netbios
Browse files Browse the repository at this point in the history
Thus avoiding double negatives.
  • Loading branch information
tdltdc committed Nov 19, 2023
1 parent fd6df50 commit ad02062
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Alternatively, you can directly import the existing playbook:
| `samba_apple_extensions` | `no` | When yes, enables support for Apple specific SMB extensions. Required for Time Machine support to work (see below) |
| `samba_create_varwww_symlinks` | `false` | When true, symlinks are created in web docroot to the shares. (`var/www/` or `/var/www/html` depending on platform) |
| `samba_cups_server` | `localhost:631` | Value for the global option `cups server` (only needed when `samba_printer_type` is "cups") |
| `samba_disable_netbios` | `false` | When true, the NMB daemon is disabled. This overrides other NetBIOS related settings. |
| `samba_enable_netbios` | `true` | When false, the NMB daemon is disabled by setting `disable netbios` to `yes`. This overrides other NetBIOS related settings. |
| `samba_domain_master` | `true` | When true, smbd enables WAN-wide browse list collation |
| `samba_global_include` | - | Samba-compatible configuration file with options to be loaded to [global] section (see below) |
| `samba_guest_account` | - | Guest account for unknown users |
Expand Down
2 changes: 1 addition & 1 deletion roles/server/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ samba_manage_directories: true
samba_shares: []
samba_users: []

samba_disable_netbios: 'no'
samba_enable_netbios: 'yes'
samba_wins_support: 'yes'
samba_local_master: 'yes'
samba_domain_master: 'yes'
Expand Down
2 changes: 1 addition & 1 deletion roles/server/handlers/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@
ansible.builtin.service:
name: "{{ nmb_service }}"
state: restarted
when: not samba_disable_netbios
when: samba_enable_netbios
2 changes: 1 addition & 1 deletion roles/server/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
state: started
enabled: true
tags: samba
when: not samba_disable_netbios
when: samba_enable_netbios

- name: Create Samba users if they don't exist yet
ansible.builtin.shell: >
Expand Down
2 changes: 1 addition & 1 deletion roles/server/templates/smb.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

{% endif %}
# Name resolution
{% if samba_disable_netbios %}
{% if not samba_enable_netbios %}
disable netbios = yes
{% endif %}
wins support = {{ samba_wins_support | ternary('yes', 'no') }}
Expand Down

0 comments on commit ad02062

Please sign in to comment.