-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to fix #19, #18, #6, #4 and #8 #20
Conversation
And #9 :-) |
Thanks for your PR, it solves my problems in Sublime3 too. I'm now waiting it to be merged, so that github highlighting will follow. |
@vkostyukov Did you get a chance to look into this pull request? |
@pchaigno Seems like a lost cause to me) |
@vkostyukov Would you be willing to take a look at this? @pchaigno Perhaps the Github team would be willing to pull this project under their wing in order to allow contributors to fix these issues so they can be made available to Github? |
@JLLeitschuh There is another project that is currently listed at linguist repo as the kotlin grammar. It is certainly better than current version of this repo, but may not be better than this PR. I'm currently trying to convince the Kotlin team to take it under Jetbrains' wing, which seems to be the better option for everybody. |
I sent an email to the repo owner. |
Thanks for your patience @JLLeitschuh and @belyaev-mikhail! I'm going to merge this in to unblock people short-term. I don't mind (and fully support) if either Github or Jetbrains want to fork this project and evolve it on their own terms. |
Thank you @vkostyukov for taking the time!
The issue is not so much who owns the repo, but rather who maintains it. You need people to review fixes.
👍 |
Also:
Checked in sublime 2, dunno about other usecases.