Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix #19, #18, #6, #4 and #8 #20

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

belyaev-mikhail
Copy link
Contributor

Also:

  • Added missing "standard" types, operators and keywords
  • Removed tuple remnants

Checked in sublime 2, dunno about other usecases.

@belyaev-mikhail
Copy link
Contributor Author

And #9 :-)

@jcornaz
Copy link

jcornaz commented Feb 15, 2018

Thanks for your PR, it solves my problems in Sublime3 too.

I'm now waiting it to be merged, so that github highlighting will follow.

@pchaigno
Copy link

@vkostyukov Did you get a chance to look into this pull request?

@belyaev-mikhail
Copy link
Contributor Author

@pchaigno Seems like a lost cause to me)

@JLLeitschuh
Copy link

@vkostyukov Would you be willing to take a look at this?

@pchaigno Perhaps the Github team would be willing to pull this project under their wing in order to allow contributors to fix these issues so they can be made available to Github?

@belyaev-mikhail
Copy link
Contributor Author

@JLLeitschuh There is another project that is currently listed at linguist repo as the kotlin grammar. It is certainly better than current version of this repo, but may not be better than this PR.

I'm currently trying to convince the Kotlin team to take it under Jetbrains' wing, which seems to be the better option for everybody.

@JLLeitschuh
Copy link

I sent an email to the repo owner.

@vkostyukov
Copy link
Owner

Thanks for your patience @JLLeitschuh and @belyaev-mikhail! I'm going to merge this in to unblock people short-term. I don't mind (and fully support) if either Github or Jetbrains want to fork this project and evolve it on their own terms.

@pchaigno
Copy link

pchaigno commented Apr 2, 2018

Thank you @vkostyukov for taking the time!

Perhaps the Github team would be willing to pull this project under their wing in order to allow contributors to fix these issues so they can be made available to Github?

The issue is not so much who owns the repo, but rather who maintains it. You need people to review fixes.

I'm currently trying to convince the Kotlin team to take it under Jetbrains' wing, which seems to be the better option for everybody.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants