Merge pull request #1355 from vivliostyle/fix/issue1354

fix: Flexbox not working on page floats (Regression in v2.28.0)
vivliostyle · Jun 28, 2024 · 88d00e9 · 88d00e9
2 parents b3ee157 + eb4b6e1
commit 88d00e9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/core/src/vivliostyle/vgen.ts b/packages/core/src/vivliostyle/vgen.ts
@@ -794,7 +794,11 @@ export class ViewFactory
  elementStyle,
  computedStyle,
  );
- if (floatReference && PageFloats.isPageFloat(floatReference)) {
+ if (
+ floatReference &&
+ PageFloats.isPageFloat(floatReference) &&
+ computedStyle["display"] === Css.ident.block
+ ) {
  // Fix page float margin collapsing issue (Issue #1282)
  computedStyle["display"] = Css.ident.flow_root;
  }