fix: Preview watch not refreshed when CSS file is changed #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up fix of #149.
src/commands/preview.ts
Outdated
| pathStartsWith(path, theme.destination), | ||
| config.themeIndexes.find( | ||
| (theme) => | ||
| (theme as any).destination !== theme.location && |
There was a problem hiding this comment.
Don't use as any. We can do type narrowing by theme.type !== 'file'.
Suggested change
| (theme as any).destination !== theme.location && | |
| (theme.type !== 'file' || theme.destination !== theme.location) && |
There was a problem hiding this comment.
修正しました。
(theme.type === 'file' || theme.type === 'package') &&
theme.destination !== theme.location &&
(theme.type === 'file'
? path === theme.destination
: pathStartsWith(path, theme.destination)),としました。 theme.type === 'package' の場合でも theme.destination !== theme.location のチェックをするべきだと考えたためです。（#160 で「ローカル theme について、いま行っている theme のファイルのコピーを行わない」ようにする提案をしています。その場合 theme.type === 'package' の場合でも theme.destination === theme.location となります。）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix of #149.