Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-node): fix when dumped module file name is greater than max file name #6447

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Sep 3, 2024

Description

When using the test.server.debug option (or the corresponding env var) and the module file path that is about to be dumped + the hash is greater than the file name max limit the dump fails (this is 255 chars in most systems)

I did not add any test as currently there is no test on the debug functionality (did not find now and in the original PR #1723)

How did I fix it:

I just hashed twice using 2 different starting values for the djb hash function (use 2 to decrease the chance for hash collision as I suspect that the original path was part of the file name because of that)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 872b5aa
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66e9703d40fb1800085d1074
😎 Deploy Preview https://deploy-preview-6447--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rluvaton rluvaton marked this pull request as ready for review September 3, 2024 16:33
@rluvaton
Copy link
Contributor Author

rluvaton commented Sep 9, 2024

@sheremet-va Can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant