Correct createlookupvindex examples #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
deepthi
approved these changes
Sep 20, 2024
frouioui
approved these changes
Sep 20, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
lookupvindex_corrections
branch
from
5cc3fb3 to
1bb7fb9
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1619 where the docs were updated to move from
vtctlclienttovtctldclientand the examples changed in https://github.com/vitessio/website/pull/1619/files#diff-3fa06a66472f0c25278194a50fa70abc88b109d64404009fc9a6c8c61be241de were not correct. For example here you can see that the workflow name and details were different between the old and new commands: https://github.com/vitessio/website/pull/1619/files#diff-3fa06a66472f0c25278194a50fa70abc88b109d64404009fc9a6c8c61be241deL220-R196The changes made are identical in all versions changed (18-21), the only difference is that in v21 the default vindex type used was changed from
binary_md5toxxhashvia vitessio/vitess#16113).Previews: