Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StalledDiskPrimary analysis and recovery to vtorc #17470

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'upstream/main' into stall-disk-recovery

3a1e118
Select commit
Loading
Failed to load commit list.
Open

Add StalledDiskPrimary analysis and recovery to vtorc #17470

Merge remote-tracking branch 'upstream/main' into stall-disk-recovery
3a1e118
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 1s

67.68% (-0.01%) compared to aabf1c9, passed because coverage increased by 0% when compared to adjusted base (67.68%)

View this Pull Request on Codecov

67.68% (-0.01%) compared to aabf1c9, passed because coverage increased by 0% when compared to adjusted base (67.68%)

Details

Codecov Report

Attention: Patch coverage is 71.15385% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.68%. Comparing base (aabf1c9) to head (3a1e118).

Files with missing lines Patch % Lines
...o/vt/vttablet/tabletmanager/disk_health_monitor.go 76.05% 17 Missing ⚠️
go/vt/vtorc/inst/instance_dao.go 54.54% 5 Missing ⚠️
go/vt/vtorc/config/config.go 0.00% 4 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 3 Missing ⚠️
go/vt/vtorc/logic/topology_recovery.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17470      +/-   ##
==========================================
- Coverage   67.68%   67.68%   -0.01%     
==========================================
  Files        1584     1585       +1     
  Lines      254466   254564      +98     
==========================================
+ Hits       172235   172293      +58     
- Misses      82231    82271      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov