Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all durability policy names constants #17448

Merged
merged 2 commits into from
Jan 5, 2025

feat: use the existing keyspace struct instead of creating a new one

adbc47d
Select commit
Loading
Failed to load commit list.
Merged

Make all durability policy names constants #17448

feat: use the existing keyspace struct instead of creating a new one
adbc47d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2025 in 1s

67.65% (-0.03%) compared to 9383943

View this Pull Request on Codecov

67.65% (-0.03%) compared to 9383943

Details

Codecov Report

Attention: Patch coverage is 76.47059% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (9383943) to head (adbc47d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/grpcvtctldserver/server.go 75.00% 3 Missing ⚠️
go/vt/vtorc/logic/topology_recovery.go 0.00% 3 Missing ⚠️
go/vt/vtctl/vtctl.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_backup.go 0.00% 2 Missing ⚠️
go/vt/wrangler/reparent.go 0.00% 2 Missing ⚠️
go/vt/wrangler/tablet.go 0.00% 2 Missing ⚠️
go/cmd/vtctldclient/command/keyspaces.go 66.66% 1 Missing ⚠️
go/vt/vtorc/inst/analysis_dao.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17448      +/-   ##
==========================================
- Coverage   67.67%   67.65%   -0.03%     
==========================================
  Files        1583     1584       +1     
  Lines      254363   254360       -3     
==========================================
- Hits       172140   172083      -57     
- Misses      82223    82277      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov