Make transaction mode a dynamic configuration #17419
Open
+301
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the changes to allow for transaction mode to be a dynamic configuration.
We already have all the viper changes in place for us to be able to do this. Tests for the same have also been added. I also refactored a little bit of how we create dynamic configs introduced in #17328. The changes allow for us to only instantiate a single dynamic config instance and pass it around everywhere.
While trying to add a
/debug/config
endpoint to vtgate, I found out that one already exists and it already shows the config values there!I also found out that we already log changes in configurations too!
Related Issue(s)
Checklist
Deployment Notes