Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Compatibility Around LAST_INSERT_ID - evalengine #17409

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

test: fix set test case

ff99643
Select commit
Loading
Failed to load commit list.
Draft

Improved Compatibility Around LAST_INSERT_ID - evalengine #17409

test: fix set test case
ff99643
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 30, 2024 in 0s

67.66% (-0.01%) compared to 9383943, passed because coverage increased by 0% when compared to adjusted base (67.67%)

View this Pull Request on Codecov

67.66% (-0.01%) compared to 9383943, passed because coverage increased by 0% when compared to adjusted base (67.67%)

Details

Codecov Report

Attention: Patch coverage is 74.41860% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (9383943) to head (ff99643).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/fn_misc.go 80.95% 4 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go 0.00% 4 Missing ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 60.00% 2 Missing ⚠️
go/vt/vtgate/evalengine/expr_env.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17409      +/-   ##
==========================================
- Coverage   67.67%   67.66%   -0.01%     
==========================================
  Files        1583     1584       +1     
  Lines      254363   254400      +37     
==========================================
+ Hits       172140   172152      +12     
- Misses      82223    82248      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov