test: Include unit tests for switcher-dry-run

[beingnoble03]

Description

This PR adds unit tests for switcher_dry_run.go.

Coverage diff:

• Coverage on main

ok  	vitess.io/vitess/go/vt/vtctl/workflow	2.733s	coverage: 64.6% of statements

• Coverage on tests-switcher-dr

ok  	vitess.io/vitess/go/vt/vtctl/workflow	2.862s	coverage: 67.2% of statements

Related Issue(s)

• Tracking Issue: vtctldclient/vtctld: Enhance test coverage and code refactor  #16499

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base (45192d2) to head (8c8edbf).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17403      +/-   ##
==========================================
+ Coverage   67.52%   67.61%   +0.08%     
==========================================
  Files        1581     1581              
  Lines      253948   253945       -3     
==========================================
+ Hits       171480   171696     +216     
+ Misses      82468    82249     -219     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattlord]

Thanks, @beingnoble03 ! Just the one nit about the struct name.

[mattlord]

IMO we should rename this to newSwitcherDryRunEnv so that it's more aligned with what it is.

[beingnoble03]

but the function returns testEnv and trafficSwitcher instance, so I thought of naming it newTrafficSwitcherEnv?

[mattlord]

OK, it's not a big deal either way. If it has nothing specifically to do with dry runs then the current name is definitely fine.