-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure PRS runs for all the shards in TestSemiSyncRequiredWithTwoPC
#17384
Merged
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:fix-TestSemiSyncRequiredWithTwoPC
Dec 12, 2024
Merged
Ensure PRS runs for all the shards in TestSemiSyncRequiredWithTwoPC
#17384
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:fix-TestSemiSyncRequiredWithTwoPC
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
harshit-gangal,
systay and
frouioui
as code owners
December 12, 2024 16:06
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 12, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 12, 2024
harshit-gangal
added
the
Backport to: release-21.0
Needs to be backport to release-21.0
label
Dec 12, 2024
harshit-gangal
approved these changes
Dec 12, 2024
dbussink
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17384 +/- ##
==========================================
- Coverage 67.47% 67.45% -0.02%
==========================================
Files 1581 1581
Lines 253944 253944
==========================================
- Hits 171353 171309 -44
- Misses 82591 82635 +44 ☔ View full report in Codecov by Sentry. |
GuptaManan100
added a commit
that referenced
this pull request
Dec 14, 2024
…#17384) Signed-off-by: Manan Gupta <[email protected]>
mattlord
pushed a commit
that referenced
this pull request
Dec 14, 2024
…uiredWithTwoPC` (#17384) (#17385) Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Query Serving
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flaky fix done in #17332, was somewhat incomplete. Post the changes, we still had a single shard left that didn't have its primary changed when we ran PRS after changing the keyspace durability policy. This causes the test to be flaky because VTOrc fixing the semi-sync races with the next transaction running.
Related Issue(s)
Checklist
Deployment Notes