Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail VTBackup early when we cannot check replication status or when MySQL has failed #17356

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

add a limit before failing replication check and fail when mysql fails

ee310c8
Select commit
Loading
Failed to load commit list.
Draft

Fail VTBackup early when we cannot check replication status or when MySQL has failed #17356

add a limit before failing replication check and fail when mysql fails
ee310c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2024 in 0s

67.48% (-0.03%) compared to 63dfb9e

View this Pull Request on Codecov

67.48% (-0.03%) compared to 63dfb9e

Details

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (63dfb9e) to head (ee310c8).

Files with missing lines Patch % Lines
go/cmd/vtbackup/cli/vtbackup.go 0.00% 17 Missing ⚠️
go/vt/mysqlctl/mysqld.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17356      +/-   ##
==========================================
- Coverage   67.51%   67.48%   -0.03%     
==========================================
  Files        1580     1580              
  Lines      253805   253822      +17     
==========================================
- Hits       171358   171303      -55     
- Misses      82447    82519      +72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov