Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] vtorc: require topo for Healthy: true in /debug/health (#17129) #17351

Draft
wants to merge 6 commits into
base: release-19.0
Choose a base branch
from

improve modified test

0139b8e
Select commit
Loading
Failed to load commit list.
Draft

[release-19.0] vtorc: require topo for Healthy: true in /debug/health (#17129) #17351

improve modified test
0139b8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 9, 2024 in 0s

4.54% of diff hit (target 65.12%)

View this Pull Request on Codecov

4.54% of diff hit (target 65.12%)

Annotations

Check warning on line 32 in go/vt/vtorc/logic/keyspace_shard_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/keyspace_shard_discovery.go#L32

Added line #L32 was not covered by tests

Check warning on line 35 in go/vt/vtorc/logic/keyspace_shard_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/keyspace_shard_discovery.go#L35

Added line #L35 was not covered by tests

Check warning on line 41 in go/vt/vtorc/logic/keyspace_shard_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/keyspace_shard_discovery.go#L41

Added line #L41 was not covered by tests

Check warning on line 57 in go/vt/vtorc/logic/keyspace_shard_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/keyspace_shard_discovery.go#L57

Added line #L57 was not covered by tests

Check warning on line 64 in go/vt/vtorc/logic/keyspace_shard_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/keyspace_shard_discovery.go#L64

Added line #L64 was not covered by tests

Check warning on line 86 in go/vt/vtorc/logic/keyspace_shard_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/keyspace_shard_discovery.go#L85-L86

Added lines #L85 - L86 were not covered by tests

Check warning on line 79 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L75-L79

Added lines #L75 - L79 were not covered by tests

Check warning on line 85 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L84-L85

Added lines #L84 - L85 were not covered by tests

Check warning on line 90 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L90

Added line #L90 was not covered by tests

Check warning on line 92 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L92

Added line #L92 was not covered by tests

Check warning on line 95 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L95

Added line #L95 was not covered by tests

Check warning on line 99 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L99

Added line #L99 was not covered by tests

Check warning on line 102 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L102

Added line #L102 was not covered by tests

Check warning on line 123 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L123

Added line #L123 was not covered by tests

Check warning on line 142 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L142

Added line #L142 was not covered by tests

Check warning on line 144 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L144

Added line #L144 was not covered by tests

Check warning on line 156 in go/vt/vtorc/logic/tablet_discovery.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/tablet_discovery.go#L156

Added line #L156 was not covered by tests

Check warning on line 424 in go/vt/vtorc/logic/vtorc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/vtorc.go#L420-L424

Added lines #L420 - L424 were not covered by tests

Check warning on line 432 in go/vt/vtorc/logic/vtorc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/vtorc.go#L430-L432

Added lines #L430 - L432 were not covered by tests

Check warning on line 437 in go/vt/vtorc/logic/vtorc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/vtorc.go#L434-L437

Added lines #L434 - L437 were not covered by tests

Check warning on line 442 in go/vt/vtorc/logic/vtorc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/vtorc.go#L440-L442

Added lines #L440 - L442 were not covered by tests

Check warning on line 447 in go/vt/vtorc/logic/vtorc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/vtorc.go#L445-L447

Added lines #L445 - L447 were not covered by tests

Check warning on line 449 in go/vt/vtorc/logic/vtorc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtorc/logic/vtorc.go#L449

Added line #L449 was not covered by tests